Features/102 reduce op docstring #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #521 +/- ##
==========================================
- Coverage 96.60% 96.60% -0.01%
==========================================
Files 68 68
Lines 14092 14091 -1
==========================================
- Hits 13613 13612 -1
Misses 479 479
Continue to review full report at Codecov.
|
coquelin77
requested changes
Apr 3, 2020
heat/core/operations.py
Outdated
| if neutral is None: | ||
| neutral = float("nan") | ||
| neutral_shape = x.lshape[:split] + (1,) + x.lshape[split + 1 :] | ||
| partial = torch.full(neutral_shape, fill_value=neutral, dtype=x._DNDarray__array.dtype) | ||
| else: | ||
| partial = x._DNDarray__array | ||
|
|
||
| # |
There was a problem hiding this comment.
resolved, comment I wanted to introduce was missing
CHANGELOG.md
Outdated
| @@ -1,5 +1,6 @@ | |||
| # Pending Additions | |||
|
|
|||
| - [#102](https://github.com/helmholtz-analytics/heat/pull/429) Add documentation for the generic reduce_op in Heat's core | |||
There was a problem hiding this comment.
normally we have the numbers representative of the PR instead of the issue number. also the link is pointing to the wrong. for this PR it would be [#521](https://github.com/helmholtz-analytics/heat/pull/521)
coquelin77
approved these changes
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Include a summary of the change/s.
Please also include relevant motivation and context. List any dependencies that are required for this change.
Issue/s resolved: #102, #448
Type of change
Remove irrelevant options:
Due Diligence
Does this change modify the behaviour of other functions? If so, which?
no