Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

float32 are now consistent default data types in factories #526

Merged
merged 2 commits into from
Apr 6, 2020

Conversation

Markus-Goetz
Copy link
Member

Description

All factories, including random now use ht.float32 as default dtype.

Issue/s resolved: #491

Type of change

Remove irrelevant options:

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

Merging #526 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #526   +/-   ##
=======================================
  Coverage   96.60%   96.60%           
=======================================
  Files          68       68           
  Lines       14094    14094           
=======================================
  Hits        13615    13615           
  Misses        479      479           
Impacted Files Coverage Δ
heat/core/random.py 100.00% <100.00%> (ø)
heat/core/tests/test_communication.py 97.20% <100.00%> (ø)
heat/core/tests/test_manipulations.py 99.29% <100.00%> (ø)
heat/core/tests/test_random.py 98.03% <100.00%> (ø)
heat/core/tests/test_statistics.py 99.30% <100.00%> (ø)
heat/regression/lasso/tests/test_lasso.py 94.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95fda46...9c6b18f. Read the comment docs.

@Markus-Goetz Markus-Goetz merged commit 0762ebd into master Apr 6, 2020
@Markus-Goetz Markus-Goetz deleted the bugfixes/491-dtype-homogenization branch April 6, 2020 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data type homogenization
2 participants