Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiles to sep class #531

Merged
merged 6 commits into from
Apr 7, 2020
Merged

Tiles to sep class #531

merged 6 commits into from
Apr 7, 2020

Conversation

coquelin77
Copy link
Member

@coquelin77 coquelin77 commented Apr 7, 2020

Description

Removal of the tiling object from the DNDarray

Issue/s resolved: N/A

Changes proposed:

  • removal of tiling object from DNDarray
  • minor changes to calls of QR
  • doc updates

Type of change

Remove irrelevant options:

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    breaking changes have been addressed in codebase
  • Documentation update

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

yes, qr functions

@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #531 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #531      +/-   ##
==========================================
- Coverage   96.28%   96.28%   -0.01%     
==========================================
  Files          75       75              
  Lines       14540    14533       -7     
==========================================
- Hits        14000    13993       -7     
  Misses        540      540              
Impacted Files Coverage Δ
heat/core/linalg/basics.py 93.65% <ø> (ø)
heat/core/dndarray.py 96.52% <100.00%> (-0.04%) ⬇️
heat/core/linalg/qr.py 99.29% <100.00%> (ø)
heat/core/tests/test_tiling.py 98.10% <100.00%> (-0.01%) ⬇️
heat/core/tiling.py 96.28% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3e91aa...ad87807. Read the comment docs.

@Markus-Goetz Markus-Goetz merged commit 6a2baf3 into master Apr 7, 2020
@Markus-Goetz Markus-Goetz deleted the tiles-to-sep-class branch April 7, 2020 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants