Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor tweaks to allow for torch 1.5 compatability #558

Merged
merged 32 commits into from
Apr 23, 2020

Conversation

coquelin77
Copy link
Member

Description

Changes done to allow for the use of the most recent pytorch release (1.5.0) see changes proposed for more detail

Issue/s resolved: None

Changes proposed:

  • memory.sanitize_memory_layout now assumes that the data is distributed in the default way, also it will not change anything if the tensor passed to the function has no elements.
  • DNDarray.redistribute uses where instead of nonzero (the usage of nonzero there was depreciated)

Type of change

Compatibility with dependency update

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

yes, anything which uses

@coquelin77
Copy link
Member Author

i have no idea why this is failing in QR. i have all test successful on both HDFML and my local machine. anyone have any ideas?

@coquelin77 coquelin77 requested review from Markus-Goetz, ClaudiaComito and bhagemeier and removed request for Markus-Goetz April 22, 2020 13:29
@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

Merging #558 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #558   +/-   ##
=======================================
  Coverage   96.39%   96.39%           
=======================================
  Files          75       75           
  Lines       14849    14849           
=======================================
  Hits        14313    14313           
  Misses        536      536           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be2b8df...be2b8df. Read the comment docs.

Copy link
Contributor

@ClaudiaComito ClaudiaComito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks, the sanitize_memory part looks good to me. Maybe, while you're at it, add a line to the docs about input and output being torch tensors, I forgot at the time and indeed it can get confusing.

@ClaudiaComito ClaudiaComito merged commit 1012a08 into master Apr 23, 2020
@Markus-Goetz Markus-Goetz deleted the torch1.5-compatability branch June 9, 2020 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants