Features/98 moments - skew and kurtosis #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #615 +/- ##
========================================
Coverage 97.46% 97.47%
========================================
Files 77 77
Lines 15470 15663 +193
========================================
+ Hits 15078 15267 +189
- Misses 392 396 +4
Continue to review full report at Codecov.
|
Markus-Goetz
requested changes
Jul 1, 2020
added reverences to skew and kurtosis cleanup, removal of useless code added warning to documentation coverage increases and removal of code block in merge moments needed for skew and kurtosis, only required if said functions support multiple axes coverage update moved to the correct alphabetical place in statistics removed excess try except in requested changes, doc strings, reordering of moments w axis
coquelin77
force-pushed
the
features/98-moments
branch
from
2390d48
to
c0fda35
Compare
Markus-Goetz
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
skew()andkurtosis()functions. Also fixed the spectral bug (hopefully)Issue/s resolved: #98
Changes proposed:
skew()kurtosis()np.infto max dtype value inheat.spatial.distance._quadratic_expandto avoid issues with MKL backendType of change
Due Diligence
Does this change modify the behaviour of other functions? If so, which?
yes,
cdistwith the use of_quadratic_expandwill not return infinite values now.