Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added balance to printing._torch_data for printing of unbalanced arrays #618

Merged
merged 1 commit into from
Jul 2, 2020

Conversation

coquelin77
Copy link
Member

Description

added balance to printing to allow for unbalanced arrays to be printed.

Issue/s resolved: #617

Changes proposed:

  • balance added to print

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

@coquelin77
Copy link
Member Author

shall this throw a warning as well when balancing during the print?

@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #618 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #618   +/-   ##
=======================================
  Coverage   97.46%   97.46%           
=======================================
  Files          77       77           
  Lines       15461    15470    +9     
=======================================
+ Hits        15069    15078    +9     
  Misses        392      392           
Impacted Files Coverage Δ
heat/core/printing.py 100.00% <100.00%> (ø)
heat/core/tests/test_printing.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb0010b...33f430f. Read the comment docs.

@Markus-Goetz Markus-Goetz merged commit 4117db8 into master Jul 2, 2020
@Markus-Goetz Markus-Goetz deleted the bug/617-printing-unbalanced-arrays branch July 2, 2020 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Printing of unbalanced arrays can result in an error
2 participants