-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/599 kmeans and friends #634
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cluster (pendant to clipping points-in-cluster to 1 in menas)
… kmedian and kmedoid due to bug
Codecov Report
@@ Coverage Diff @@
## master #634 +/- ##
==========================================
- Coverage 97.40% 97.27% -0.13%
==========================================
Files 79 84 +5
Lines 16126 16535 +409
==========================================
+ Hits 15708 16085 +377
- Misses 418 450 +32
Continue to review full report at Codecov.
|
Markus-Goetz
requested changes
Jul 17, 2020
Markus-Goetz
approved these changes
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation of kmedians and kmedoids-version (kmedians snaped to nearest data point). Along that line, kmeans was refactored by introducing a base class _kcluster, that handles centroid initialization, predict function and assigning data points to the respective cluster centers. Kmeans, kmedians and kmedoids are derivatives of _kcluster with specific metrics (euclidean, manhattan) and different implementations of the centroid updating function.
Issue/s resolved: #409 #599
Changes proposed:
Type of change
Due Diligence
Does this change modify the behaviour of other functions? If so, which?
no