-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for pytorch 1.6.0 #653
Conversation
these tests will not run on GPU. is there a reason that we cant use the torch argmax/argmin for the tests? |
…holtz-analytics/heat into bug/argmin_argmax_unittests
Codecov Report
@@ Coverage Diff @@
## master #653 +/- ##
==========================================
- Coverage 97.40% 97.37% -0.03%
==========================================
Files 85 85
Lines 16636 16646 +10
==========================================
+ Hits 16204 16209 +5
- Misses 432 437 +5
Continue to review full report at Codecov.
|
build failing -> due to issues with jenkins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me and tests are passing
Description
Update the unittests for argmax and argmin for the changed return behaviour (numpy like) resulting from changes in pytorch 1.6.0 (torch.max, torch.min return first value).
Additionally, mpi_argmax and mpi_argmin sort the inputs by starting index beforehand. Some MPI implementations do not bind the first input to the lower process.
Changes proposed:
Type of change
Due Diligence
Does this change modify the behaviour of other functions? If so, which?
Unknown