Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reshape boolean bug #684

Merged
merged 3 commits into from
Oct 13, 2020
Merged

fix reshape boolean bug #684

merged 3 commits into from
Oct 13, 2020

Conversation

mtar
Copy link
Collaborator

@mtar mtar commented Oct 9, 2020

Description

Fixes the reshape bug on booleans and on floats in some cases. Some tensors were using the dtype of the input by mistake.

Issue/s resolved: #682
Issue/s resolved: #654

Changes proposed:

  • fix reshape on booleans

Type of change

Bug fix

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

@mtar mtar marked this pull request as ready for review October 9, 2020 11:34
@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #684 into release/0.5.x will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           release/0.5.x     #684   +/-   ##
==============================================
  Coverage          97.46%   97.46%           
==============================================
  Files                 87       87           
  Lines              17094    17101    +7     
==============================================
+ Hits               16660    16667    +7     
  Misses               434      434           
Impacted Files Coverage Δ
heat/core/manipulations.py 99.22% <100.00%> (ø)
heat/core/tests/test_manipulations.py 99.92% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60101b4...59e5ef5. Read the comment docs.

Copy link
Collaborator

@lenablind lenablind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - Thank you for fixing the bug!

@mtar mtar removed the request for review from Markus-Goetz October 9, 2020 13:08
@mtar mtar linked an issue Oct 9, 2020 that may be closed by this pull request
@coquelin77 coquelin77 merged commit 88f9157 into release/0.5.x Oct 13, 2020
@coquelin77 coquelin77 deleted the bug/682-reshape_boolean branch October 13, 2020 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reshape for distributed boolean DNDarray
3 participants