Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify code coverage #720

Merged
merged 8 commits into from
Feb 4, 2021
Merged

modify code coverage #720

merged 8 commits into from
Feb 4, 2021

Conversation

mtar
Copy link
Collaborator

@mtar mtar commented Feb 3, 2021

Description

Issue/s resolved: #719

Changes proposed:

  • ignore code coverage of test files
  • allow coverage to drop by 5%

Type of change

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

skip ci

@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #720 (81d32ed) into master (e26f946) will decrease coverage by 2.74%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #720      +/-   ##
==========================================
- Coverage   97.11%   94.37%   -2.75%     
==========================================
  Files          87       50      -37     
  Lines       18460     7390   -11070     
==========================================
- Hits        17927     6974   -10953     
+ Misses        533      416     -117     
Flag Coverage Δ
unit 94.37% <ø> (?)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
heat/naive_bayes/tests/test_gaussiannb.py
heat/cluster/tests/test_spectral.py
heat/graph/tests/test_laplacian.py
heat/core/tests/test_relational.py
heat/core/tests/test_dndarray.py
heat/core/linalg/tests/test_solver.py
heat/core/linalg/tests/test_basics.py
heat/core/tests/test_communication.py
heat/core/tests/test_operations.py
heat/core/tests/test_trigonometrics.py
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e26f946...81d32ed. Read the comment docs.

@mtar mtar marked this pull request as ready for review February 3, 2021 16:12
@mtar mtar marked this pull request as draft February 3, 2021 16:14
@mtar mtar marked this pull request as ready for review February 3, 2021 16:17
@mtar mtar marked this pull request as draft February 3, 2021 16:18
@mtar mtar requested a review from bhagemeier February 4, 2021 12:53
@mtar mtar marked this pull request as ready for review February 4, 2021 12:53
Copy link
Member

@bhagemeier bhagemeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally agree with the changes. However, we may need to adjust the margin to be somewhat tighter than 5%. I assume that the drop by 2.75% in this case is due to the fact that all tests, which are covered to 100% by nature, have been removed from the coverage. OTOH, an addition of roughly 5% untested code is difficult to achieve the larger the project grows.

@bhagemeier bhagemeier merged commit e3fea8a into master Feb 4, 2021
@bhagemeier bhagemeier deleted the enhancement/719-coverage branch February 4, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for minor decreases in code coverage when merging branches
2 participants