-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify code coverage #720
modify code coverage #720
Conversation
Codecov Report
@@ Coverage Diff @@
## master #720 +/- ##
==========================================
- Coverage 97.11% 94.37% -2.75%
==========================================
Files 87 50 -37
Lines 18460 7390 -11070
==========================================
- Hits 17927 6974 -10953
+ Misses 533 416 -117
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
6f6ea82
to
d5f9b93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I generally agree with the changes. However, we may need to adjust the margin to be somewhat tighter than 5%. I assume that the drop by 2.75% in this case is due to the fact that all tests, which are covered to 100% by nature, have been removed from the coverage. OTOH, an addition of roughly 5% untested code is difficult to achieve the larger the project grows.
Description
Issue/s resolved: #719
Changes proposed:
Type of change
Due Diligence
Does this change modify the behaviour of other functions? If so, which?
no
skip ci