-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
504 docstring formatting #757
Conversation
…ng tensor for array/DNDarray
…ng tensor for array/DNDarray
…tz-analytics/heat into 504-docstring-formatting
Codecov Report
@@ Coverage Diff @@
## master #757 +/- ##
==========================================
- Coverage 95.87% 95.21% -0.66%
==========================================
Files 64 64
Lines 8630 8717 +87
==========================================
+ Hits 8274 8300 +26
- Misses 356 417 +61
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…int rounding errors
…numerical instability. cause is still unknown
rerun tests |
setup.py
Outdated
@@ -40,8 +39,9 @@ | |||
"torchvision>=0.5.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
outdated dependencies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think that torch would supersede this anyway, but it can be updated as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i updated it to match the requirements of torch 1.7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean all listed requirements. Many of them are not working with python3.7+. Only the last line came up here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which ones dont work with 3.7?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
numpy scipy mpi4py pillow; I had problems using the lowest version when I tried them on python 3.8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
your package manager should take care of which is the best implementation which fits these requirements for your python version
…tz-analytics/heat into 504-docstring-formatting
…tz-analytics/heat into 504-docstring-formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the rendering, looks good. We are ready for production
Description
New docstrings with custom formatting! major changes to almost every function. Special shoutout to @Cdebus for the organization and heavy lifting for these changes!
Issue/s resolved: #504
Changes proposed:
Type of change
Due Diligence
Does this change modify the behaviour of other functions? If so, which?
no