meshgrid implementation #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #794 +/- ##
==========================================
+ Coverage 95.29% 95.31% +0.01%
==========================================
Files 64 64
Lines 8972 9000 +28
==========================================
+ Hits 8550 8578 +28
Misses 422 422
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…/heat into feature/775-meshgrid
heat/core/factories.py
Outdated
| grids = list(grids) | ||
| grids[0], grids[1] = grids[1], grids[0] | ||
|
|
||
| return list(asarray(grid, is_split=splitted) for grid in grids) |
There was a problem hiding this comment.
Can we use DNDarray() here instead of asarray()?
coquelin77
requested changes
Jun 24, 2021
coquelin77
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements meshgrid functionality to Heat. It uses the pytorch function of the same name. That function does not support the indexing parameter. As a hotfix for now, the first and second vector are switched during computation when using 'xy'. If the split is on the first or second axis, they are resplitted beforehand.
Issue/s resolved: #775
Changes proposed:
Type of change
Due Diligence
Does this change modify the behaviour of other functions? If so, which?
no