Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/825 setitem slice dndarrays #826

Merged
merged 23 commits into from
Jul 20, 2021
Merged

Bug/825 setitem slice dndarrays #826

Show file tree
Hide file tree
Changes from 21 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
639cd57
setitem can now set values with DNDarrays which are not the same size…
coquelin77 Jun 29, 2021
d1a0e55
added new test cases (simple)
coquelin77 Jun 29, 2021
28c268f
added oop redistribute to manipulations
coquelin77 Jun 29, 2021
61266c1
changelog update
coquelin77 Jun 29, 2021
174c792
added more test cases to increase coveraged and removed some dead code
coquelin77 Jun 29, 2021
1938f4a
abstracted section of setitem: key slice generation
coquelin77 Jul 8, 2021
66851a5
Merge branch 'master' into bug/825-setitem-slice-dndarrays
coquelin77 Jul 8, 2021
94af9f4
used key logic in getitem, added typehints/simple docstring to xitem_…
coquelin77 Jul 8, 2021
e4f5364
corrected false logic in key start stop adjustments
coquelin77 Jul 8, 2021
4960951
Merge branch 'master' into bug/825-setitem-slice-dndarrays
coquelin77 Jul 13, 2021
2a82e05
added a raise in setitem for when the value and self have different s…
coquelin77 Jul 13, 2021
dc77f17
Merge branch 'master' into bug/825-setitem-slice-dndarrays
coquelin77 Jul 13, 2021
30e2df4
added handling for single value DNDarrays in key for setitem
coquelin77 Jul 13, 2021
755c786
corrected try/expect in setitem to work with torch tensors as well
coquelin77 Jul 13, 2021
fe6ad27
Merge branch 'master' into bug/825-setitem-slice-dndarrays
coquelin77 Jul 19, 2021
8d08330
removing dead code
coquelin77 Jul 20, 2021
f193b0b
Verb correction in lshape map creation
coquelin77 Jul 20, 2021
34ba9c5
new changelog to add pending additions again
coquelin77 Jul 20, 2021
2affb59
Merge branch 'bug/825-setitem-slice-dndarrays' of https://github.com/…
coquelin77 Jul 20, 2021
3ec7b44
added tests for lshape map property and forced creation
coquelin77 Jul 20, 2021
cf8aa1a
corrected incorrect changelog, wrong line was moved the the pending a…
coquelin77 Jul 20, 2021
bf39b25
added raise test for splits != case in setitem
coquelin77 Jul 20, 2021
89fb977
new raise test now only runs on multiple processes
coquelin77 Jul 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# Pending additions

## Bug Fixes
- [#826](https://github.com/helmholtz-analytics/heat/pull/826) Fixed `__setitem__` handling of distributed `DNDarray` values which have a different shape in the split dimension


# v1.1.0

## Highlights
Expand Down
Loading