-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vdot implementation #842
vdot implementation #842
Conversation
Codecov Report
@@ Coverage Diff @@
## master #842 +/- ##
=======================================
Coverage 95.48% 95.48%
=======================================
Files 64 64
Lines 9454 9459 +5
=======================================
+ Hits 9027 9032 +5
Misses 427 427
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything looks good here, just one comment
conflicts on this branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @mtar ! Just a few minor changes needed, this one can be merged soon as far as I'm concerned.
Description
vdot implementation
Issue/s resolved: #839
Changes proposed:
Type of change
Due Diligence
Does this change modify the behaviour of other functions? If so, which?
yes / no