Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

torchvision version range compatibility with pytorch version #864

Merged
merged 4 commits into from
Sep 8, 2021

Conversation

ClaudiaComito
Copy link
Contributor

@ClaudiaComito ClaudiaComito commented Sep 6, 2021

Description

Current torchvision version 0.10 requires PyTorch 1.9, which we are not supporting with Heat 1.1.x.

Changes proposed:

  • Constraining torchvision<0.10 to match the supported pytorch version range.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

@codecov
Copy link

codecov bot commented Sep 6, 2021

Codecov Report

Merging #864 (97af229) into release/1.1.x (fdc6e7c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           release/1.1.x     #864   +/-   ##
==============================================
  Coverage          95.30%   95.30%           
==============================================
  Files                 64       64           
  Lines               9004     9004           
==============================================
  Hits                8581     8581           
  Misses               423      423           
Flag Coverage Δ
gpu 94.43% <ø> (ø)
unit 90.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
heat/core/dndarray.py 97.12% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdc6e7c...97af229. Read the comment docs.

@ClaudiaComito ClaudiaComito changed the base branch from master to release/1.1.x September 6, 2021 04:07
@ClaudiaComito ClaudiaComito merged commit ed43f09 into release/1.1.x Sep 8, 2021
@ClaudiaComito ClaudiaComito deleted the install/torchvision_version branch September 8, 2021 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants