Update handlebars to 3.0.0 #185
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… match handlebars
|
sorry for the delay, might be able to merge this sometime today. if not I'll try tomorrow. thanks! |
|
closing since this project was refactored and uses a newer handlebars (however, we'll be removing handlebars completely in an upcoming release) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to assemble/assemble-handlebars#22
This updates the handlebars dependency to 3.0.0.
It only failed one test and that was in
utils_test.js:I'm not too familiar with the inner workings of the particular util, but I tracked down how handlebars tests the same util here.
Heres the relevant issue for it.
Now Handlebars is updated and the tests are updated to Handlebars' own spec.
Woot