Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ipynb visualizations #62

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Adds ipynb visualizations #62

merged 1 commit into from
Oct 17, 2023

Conversation

timr11
Copy link
Contributor

@timr11 timr11 commented Oct 14, 2023

Addresses issue #61

fixes #61
fixes #13

Earlier, we wanted to visualize supply chains in .ipynb's and have them be interactive. Used notebookjs, as per Harry's suggestion, to implement the visualizations in JS and render them in python. This is that code.

@timr11 timr11 self-assigned this Oct 14, 2023
@devhawk
Copy link
Collaborator

devhawk commented Oct 17, 2023

One small nit: there are three display_graph code blocks in the ipynb notebook, but the visualization is always rendered in the james_kitchen code block. Will open separate issue to track this so that we can merge the visualization code

Copy link
Collaborator

@RobertLRead RobertLRead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devhawk says this is good. Good work, @timr11 !

Copy link
Collaborator

@devhawk devhawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed en mass on 10/17 project data discord mtg

@devhawk devhawk merged commit 0c51239 into main Oct 17, 2023
3 checks passed
@devhawk devhawk deleted the ipynb-visualizations branch October 17, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need and upload of Current visualization Code Need a better Visual Presentation of a fulfillment Plan
3 participants