Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to var search #349

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Fix to var search #349

merged 2 commits into from
Apr 19, 2024

Conversation

vladimir2217
Copy link
Collaborator

No description provided.

@vladimir2217 vladimir2217 marked this pull request as ready for review April 18, 2024 19:16
gaurav
gaurav approved these changes Apr 19, 2024
View reviewed changes
Copy link
Collaborator

@gaurav gaurav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As usual, I don't have a way to test this out, but the changes in the PR make sense to me! (Incidentally, it would be great to add a code formatter like Black to this repo so that our code here is consistenly formatted and therefore hopefully easier to read. I've filed this at #350).

@vladimir2217 vladimir2217 merged commit 2733f78 into develop Apr 19, 2024
8 checks passed
@vladimir2217 vladimir2217 deleted the VG2 branch April 19, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaurav gaurav gaurav approved these changes

@YaphetKG YaphetKG Awaiting requested review from YaphetKG

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vladimir2217 @gaurav