fix: aviod infinite loop

hemengke1997 · Dec 19, 2022 · 869f9e2 · 869f9e2
1 parent f91e550
commit 869f9e2
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 9 deletions.
diff --git a/README-zh.md b/README-zh.md
@@ -56,6 +56,8 @@ import type { HtmlTagDescriptor } from 'vite'
 import { defineConfig } from 'vite'
 import { publicTypescript } from 'vite-plugin-public-typescript'
 import react from '@vitejs/plugin-react'
+import fs from 'node:fs'
+import path from 'node:path'
 
 // https://vitejs.dev/config/
 export default defineConfig({
@@ -70,13 +72,15 @@ export default defineConfig({
     {
       name: 'add-script',
       async transformIndexHtml(html) {
-        const { spa } = await import('./publicTypescript/manifest.json')
+        const manifest =
+          JSON.parse(fs.readFileSync(path.resolve(__dirname, './publicTypescript/manifest.json'), 'utf-8') || '{}') ||
+          {}
 
         const tags: HtmlTagDescriptor[] = [
           {
             tag: 'script',
             attrs: {
-              src: spa,
+              src: manifest.spa,
             },
             injectTo: 'head-prepend',
           },

diff --git a/README.md b/README.md
@@ -50,11 +50,14 @@ Or you can use [`vite-plugin-html`](https://github.com/vbenjs/vite-plugin-html)
 For full example, please see [spa playground](./playground/spa/vite.config.ts)
 
 #### vite config
+
 ```typescript
 import type { HtmlTagDescriptor } from 'vite'
 import { defineConfig } from 'vite'
 import { publicTypescript } from 'vite-plugin-public-typescript'
 import react from '@vitejs/plugin-react'
+import fs from 'node:fs'
+import path from 'node:path'
 
 // https://vitejs.dev/config/
 export default defineConfig({
@@ -69,13 +72,15 @@ export default defineConfig({
     {
       name: 'add-script',
       async transformIndexHtml(html) {
-        const { spa } = await import('./publicTypescript/manifest.json')
+        const manifest =
+          JSON.parse(fs.readFileSync(path.resolve(__dirname, './publicTypescript/manifest.json'), 'utf-8') || '{}') ||
+          {}
 
         const tags: HtmlTagDescriptor[] = [
           {
             tag: 'script',
             attrs: {
-              src: spa,
+              src: manifest.spa,
             },
             injectTo: 'head-prepend',
           },
@@ -97,6 +102,7 @@ We can easily change the html in SSR mode, because `html` is just a string templ
 For full example, please see [ssr playground](./playground/ssr/index.html)
 
 #### vite config
+
 ```typescript
 import { HtmlTagDescriptor, defineConfig } from 'vite'
 import { publicTypescript } from 'vite-plugin-public-typescript'
@@ -115,15 +121,15 @@ export default defineConfig({
 ```
 
 #### server.js
+
 ```js
 import manifest from './publicTypescript/custom-manifest.json' assert { type: 'json' }
 
 const html = template
-      // inject js
-      .replace(`<!--app-prehead-->`, `<script src=${manifest.ssr}></script>`)
+  // inject js
+  .replace(`<!--app-prehead-->`, `<script src=${manifest.ssr}></script>`)
 ```
 
-
 ## Options
 
 | Parameter      | Types          | Default            | Description                                           |

diff --git a/playground/spa/vite.config.ts b/playground/spa/vite.config.ts
@@ -1,6 +1,8 @@
 import { defineConfig, HtmlTagDescriptor } from 'vite'
 import { publicTypescript } from 'vite-plugin-public-typescript'
 import react from '@vitejs/plugin-react'
+import fs from 'node:fs'
+import path from 'node:path'
 
 // https://vitejs.dev/config/
 export default defineConfig({
@@ -15,13 +17,15 @@ export default defineConfig({
     {
       name: 'add-script',
       async transformIndexHtml(html) {
-        const { spa } = await import('./publicTypescript/manifest.json')
+        const manifest =
+          JSON.parse(fs.readFileSync(path.resolve(__dirname, './publicTypescript/manifest.json'), 'utf-8') || '{}') ||
+          {}
 
         const tags: HtmlTagDescriptor[] = [
           {
             tag: 'script',
             attrs: {
-              src: spa,
+              src: manifest.spa,
             },
             injectTo: 'head-prepend',
           },