Rework single-gen streaming #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now has its own packet and element seperate from actions. Fixes several bugs related to desyncing. Also adds smooth typing effect (fixes henk717#263)
sometimes the good solution is the best solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2 because the first one was too invasive
Streaming (for single gen) now has its own packet and element and is separated from the backend actions storage. this fixes a lot of REALLY ANNOYING!!!! bugs (desync/action misalign) in the editor (at least in adventure mode). also added new "Smooth Streaming" setting that does fake character by character streaming