Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More api fixes #438

Merged
merged 5 commits into from
Aug 19, 2023
Merged

More api fixes #438

merged 5 commits into from
Aug 19, 2023

Conversation

one-some
Copy link

@one-some one-some commented Aug 14, 2023

  • Fixes model API loading failing due to renamed/changed quantization var
  • Changes WI uid values to be ints everywhere(?) instead of strings. they appear to have been ints at the time of creating the api, as the reference responses show ints being returned. this:
    • Makes the api return the right datatype (compatibility issue?)
    • Fixes most of the api WI bugs (wrote a hacky testing script that seems to show all wi endpoints working)
    • Probably fixes non-api WI bugs (a lot of them had to do with mismatching datatypes)
    • May break WI. Testing shows UI1 and UI2 seemingly working

@one-some one-some marked this pull request as ready for review August 14, 2023 18:36
@one-some
Copy link
Author

this should be ready for review now

@henk717 henk717 merged commit 029e873 into henk717:united Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants