Merge pull request #7 from henningandersen/spacetime_transactions_pre…

…pare_more Spacetime transactions prepare more
henningandersen · Nov 19, 2021 · 84a09e1 · 84a09e1
2 parents 6d9d61c + 70aa582
commit 84a09e1
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 1 deletion.
diff --git a/server/src/main/java/org/elasticsearch/index/shard/ShardTransactionRegistry.java b/server/src/main/java/org/elasticsearch/index/shard/ShardTransactionRegistry.java
@@ -51,7 +51,7 @@ public synchronized Map<TxID, Boolean> prepare(TxID txID) {
         Set<String> conflictingKeys = conflictingKeysByTxID.get(txID);
         if (conflictingKeys != null) {
             return conflictingKeys.stream().flatMap(id -> byKey.get(id).stream())
-                .filter(conflict -> conflict.equals(txID) == false).collect(Collectors.toMap(Function.identity(),
+                .filter(conflict -> conflict.equals(txID) == false).distinct().collect(Collectors.toMap(Function.identity(),
                 this::winConflict));
         } else {
             return Map.of();

diff --git a/server/src/test/java/org/elasticsearch/index/shard/ShardTransactionRegistryTests.java b/server/src/test/java/org/elasticsearch/index/shard/ShardTransactionRegistryTests.java
@@ -11,11 +11,14 @@
 import org.elasticsearch.action.bulk.TxID;
 import org.elasticsearch.test.ESTestCase;
 
+import java.util.Map;
 import java.util.Set;
 import java.util.stream.Collectors;
 import java.util.stream.IntStream;
 
+import static org.hamcrest.Matchers.empty;
 import static org.hamcrest.Matchers.equalTo;
+import static org.hamcrest.Matchers.is;
 
 public class ShardTransactionRegistryTests extends ESTestCase {
     private final ShardTransactionRegistry registry = new ShardTransactionRegistry();
@@ -42,6 +45,37 @@ public void testRegisterAndUnregister() {
         assertThat(registry.size(), equalTo(0));
     }
 
+    public void testPrepare() {
+        Set<String> ids1 = ids(0, 100);
+        Set<String> ids2 = ids(50, 150);
+        Set<String> ids3 = ids(100, 200);
+        Set<String> ids4 = ids(200, 300);
+
+        TxID txID1 = TxID.create();
+        TxID txID2 = TxID.create();
+        TxID txID3 = TxID.create();
+        TxID txID4 = TxID.create();
+        registry.registerTransaction(txID1, ids1);
+        registry.registerTransaction(txID2, ids2);
+        registry.registerTransaction(txID3, ids3);
+        registry.registerTransaction(txID4, ids4);
+
+        Map<TxID, Boolean> prepared1 = registry.prepare(txID1);
+        Map<TxID, Boolean> prepared2 = registry.prepare(txID2);
+        Map<TxID, Boolean> prepared3 = registry.prepare(txID3);
+        Map<TxID, Boolean> prepared4 = registry.prepare(txID4);
+
+        assertThat(prepared1.entrySet().size(), equalTo(1));
+        assertThat(prepared1.get(txID2), is(true));
+        assertThat(prepared2.entrySet().size(), equalTo(2));
+        assertThat(prepared2.get(txID1), is(false));
+        assertThat(prepared2.get(txID3), is(true));
+        assertThat(prepared3.entrySet().size(), equalTo(1));
+        assertThat(prepared3.get(txID2), is(false));
+        assertThat(prepared4.entrySet(), empty());
+        // need some more around already conflicted but now removed txs
+    }
+
     private Set<String> ids(int startInclusive, int endExclusive) {
         return IntStream.range(startInclusive, endExclusive).mapToObj(String::valueOf).collect(Collectors.toSet());
     }