This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
Add option to save user's selected extras #15 & Misc Fixes #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Remove unused directives. 2. hasPermission method was misspelt, fixed. 3. Write UnauthorizedAccessException to console, probably won't be useful but #fixallthewarnings
I don't forsee any issues with this, it doesn't do any special checking for if the manifest changes in the future but it shouldn't matter, if the entries don't exist it simply won't check anything. I also changed all occurences of FindSteamSkinDir() to SteamSkinPath since that String already existed. I should have included that in the previous commit but only noticed as I was adding in the save extras code. And lastly I moved the reading of the manifest out of the for loop, certainly doesn't need to be redone each iteration of the loop, again this could have been including in previous commit but I didn't realize at the time.
PhantomGamers
changed the title
|
Hi! Thanks a lot! The code looks great from my phone. I'll look at it as soon as I can. |
henrikx
approved these changes
Jul 29, 2018
| @@ -20,20 +16,21 @@ public MainForm() | |||
| { | |||
| InitializeComponent(); | |||
| CheckForIllegalCrossThreadCalls = false; | |||
| if (!hasPerimssion(FindSteamSkinDir())) | |||
| if (!hasPermission(FindSteamSkinDir())) | |||
There was a problem hiding this comment.
If Steam directory isn't found in registry, it will try to look for permission in C:, and will display it doesn't have permission
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #15