forked from go-gitea/gitea
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Avoid duplicate JS error messages on UI (go-gitea#28873)
Gitea treat JS errors seriously, so sometimes the JS errors caused by 3rdparty code (eg: browser extensions) would also be reported on Gitea UI: TypeError: WeakMap key undefined (caused by extension DarkReader's bug) go-gitea#28861 To avoid fill the user's screen with a lot of error messages, this PR merges the same error messages into one, like this: ```js <div class="page-content"> <div class="... js-global-error" data-global-error-msg-compact="testmsg1" data-global-error-msg-count="2">test msg 1 (2)</div> <div class="... js-global-error" data-global-error-msg-compact="testmsg2" data-global-error-msg-count="1">test msg 2</div> </div> ```
- Loading branch information
1 parent
77c1eac
commit 517a2ce
Showing
3 changed files
with
29 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
import {showGlobalErrorMessage} from './bootstrap.js'; | ||
|
||
test('showGlobalErrorMessage', () => { | ||
document.body.innerHTML = '<div class="page-content"></div>'; | ||
showGlobalErrorMessage('test msg 1'); | ||
showGlobalErrorMessage('test msg 2'); | ||
showGlobalErrorMessage('test msg 1'); // duplicated | ||
|
||
expect(document.body.innerHTML).toContain('>test msg 1 (2)<'); | ||
expect(document.body.innerHTML).toContain('>test msg 2<'); | ||
expect(document.querySelectorAll('.js-global-error').length).toEqual(2); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
window.__webpack_public_path__ = ''; | ||
|
||
window.config = { | ||
csrfToken: 'test-csrf-token-123456', | ||
pageData: {}, | ||
|