Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quotes in kubeadm config files #224

Merged
merged 1 commit into from
Oct 12, 2018
Merged

Add quotes in kubeadm config files #224

merged 1 commit into from
Oct 12, 2018

Conversation

vincepri
Copy link
Contributor

Signed-off-by: Vince Prignano vince@vincepri.com

@vincepri vincepri requested a review from detiber October 11, 2018 19:49
@timothysc
Copy link
Contributor

/assign @chuckha

Signed-off-by: Vince Prignano <vince@vincepri.com>
Copy link
Member

@chuckha chuckha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. yaml surprises me quite often. this time it's that i'm pretty surprised the ttl value 0s parsed correctly before

@chuckha chuckha merged commit 13c2794 into heptio:master Oct 12, 2018
johnSchnake pushed a commit to johnSchnake/aws-quickstart that referenced this pull request Feb 26, 2019
Signed-off-by: Vince Prignano <vince@vincepri.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants