Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add canvas rotation using NumPad + KeyPad numbers #3

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

larpon
Copy link

@larpon larpon commented Oct 17, 2019

  • Add Qt::KeypadModifier to known modifier keys
  • Add Rotate Canvas (Anti) Clockwise key bindings
  • Start of WIP showing Key Bindings in tool tips

* Add Rotate Canvas (Anti) Clockwise key bindings
* Start of WIP showing Key Bindings in tool tips
@larpon
Copy link
Author

larpon commented Oct 22, 2019

@herace are issues unavailable on forks?

@Jose-Moreno
Copy link

@larpon They shouldn't be, possible @herace has to enable permissions so other github members can submit issues as seen on this stackoverflow answer: https://softwareengineering.stackexchange.com/questions/179468/forking-a-repo-on-github-but-allowing-new-issues-on-the-fork

@larpon
Copy link
Author

larpon commented Oct 22, 2019

Ah thanks for clarifying @Jose-Moreno

@herace
Copy link
Owner

herace commented Nov 11, 2019

Hey @larpon sorry for the long wait, wow honestly wasn't expecting contributors so soon. Going to take a look at this 👍

@larpon
Copy link
Author

larpon commented Nov 11, 2019

Hey @herace - no worries :) I can't promise a steady pace anyway. I thought I'd just start with getting to know some internals :)

@larpon
Copy link
Author

larpon commented Nov 11, 2019

The tool tip showing is a bit crude and should probably be wrapped somehow.

@herace
Copy link
Owner

herace commented Nov 13, 2019

Hey @larpon just complied and i personally found theses canvas rotate hotkeys very useful, good stuff. Also dont worry how crude it is, as long it improve the overall user experience 👍.

Also I think focusing on adding shortcuts will definitely be a big major step improving this application.

Forgot to mention it but good work on getting rid of those compile warnings, its nice to compile something without the constant background noise. Good stuff 👍

And lastly dont worry about keeping up a constant stream of commits, go at your own pace :) 👌

@herace herace merged commit 5fe451a into herace:master Nov 13, 2019
@larpon
Copy link
Author

larpon commented Nov 13, 2019

@herace - awesome! Thanks for taking your time. I'll probably work a little more on adding some tool tips :)

@larpon larpon deleted the feature/rotate-canvas-with-numpad branch November 13, 2019 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants