Add additional unit tests for yum lense #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I usually add a |
|
My primary worry is that I'm doing the testing wrong.... if I'm not, this is a real bug that I'm not sure how to fix. |
|
After a night's sleep, I realized what was wrong with my tests. In theory I'm now running the tests right and should have more coverage than before. |
|
rebased off master |
|
rebased off master |
|
This change does not fail any tests - were you expecting it to fail on the yum lens ? |
|
Nope i was just adding some coverage to the yum lense and providing a
syntax cheat sheet for when i do this sort of thing.
…On Sat, Dec 3, 2022, 4:13 AM George Hansper ***@***.***> wrote:
This change does not fail any tests - were you expecting it to fail on the
yum lens ?
—
Reply to this email directly, view it on GitHub
<#677 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2673Q73XZYU6ZBSDHGFFTWLMMNVANCNFSM4NS7ONGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing a new lense using logic from this lense I uncovered unexpected behaviour with whitespace.
The tests added here expose this oddity.