Modified NetworkManager lense #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. Could you add tests to identify the current issue and validate the fix please? |
mchf
force-pushed
the
fixed-networkmanager-lense
branch
3 times, most recently
from
cc4770b
to
f6bbe41
Compare
|
I've added some test for the |
The lense will not encapsulate value of a newly created entry by quotes. Values containing # are accepted (allowed character e.g. for WPA-PSK)
mchf
force-pushed
the
fixed-networkmanager-lense
branch
from
f6bbe41
to
2671d01
Compare
|
ok, even |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lense will not encapsulate value of a newly created entry by quotes.
Values containing # are accepted (allowed character e.g. for WPA-PSK)
Details
E.g. # and space character are included in this range.