Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report errors when trying to using optional ranges #250

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

VeaaC
Copy link
Collaborator

@VeaaC VeaaC commented Nov 14, 2024

@range attribute cannot be combined with @optional: Users should store empty ranges instead (see #249).

This change make sure to report an error

14:30:42 - CRITICAL - app:71 - Error reading schema: @range cannot be combined with @optional, store empty ranges instead: edges_range 

For this schema:

namespace foo{
const u32 NO_EDGES_REF = 200;
struct Node {
    @range(edges_range)
    @optional( NO_EDGES_REF )
    first_edge_ref : u32;
}
}

Signed-off-by: Christian Vetter <christian.vetter@here.com>
@boxdot boxdot self-assigned this Nov 14, 2024
@boxdot boxdot self-requested a review November 14, 2024 13:35
@boxdot boxdot removed their assignment Nov 14, 2024
Signed-off-by: Christian Vetter <christian.vetter@here.com>
@VeaaC VeaaC merged commit 8c83903 into heremaps:master Nov 14, 2024
9 checks passed
@VeaaC VeaaC deleted the veaac-opt-range branch November 14, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants