PipelineBuilder: commonDsl is added each time build() is called #65
Labels
Comments
mnonnenmacher
added a commit
that referenced
this issue
Feb 7, 2018
Pass the common DSL closure to the build method of the job builder instead of adding it to the list of dsl closures. This prevents it from being added multiple times when PipelineBuilder.build() is called multiple times.
mnonnenmacher
added a commit
that referenced
this issue
Feb 7, 2018
Pass the common DSL closure to the build method of the job builder instead of adding it to the list of dsl closures. This prevents it from being added multiple times when PipelineBuilder.build() is called multiple times.
mnonnenmacher
added a commit
that referenced
this issue
Feb 7, 2018
Pass the common DSL closure to the build method of the job builder instead of adding it to the list of dsl closures. This prevents it from being added multiple times when PipelineBuilder.build() is called multiple times.
mnonnenmacher
added a commit
that referenced
this issue
Feb 7, 2018
Pass the common DSL closure to the build method of the job builder instead of adding it to the list of dsl closures. This prevents it from being added multiple times when PipelineBuilder.build() is called multiple times. Add byte-buddy to the test dependencies to enable Spock to mock PipelineJobBuilder which is not an interface [1][2]. [1] http://spockframework.org/spock/docs/1.1/all_in_one.html#_mocking_classes [2] http://spockframework.org/spock/docs/1.1/all_in_one.html#_1_1_rc_3_released_2016_10_17
mnonnenmacher
added a commit
that referenced
this issue
Jun 25, 2018
Pass the common DSL closure to the build method of the job builder instead of adding it to the list of dsl closures. This prevents it from being added multiple times when PipelineBuilder.build() is called multiple times. Add byte-buddy to the test dependencies to enable Spock to mock PipelineJobBuilder which is not an interface [1][2]. [1] http://spockframework.org/spock/docs/1.1/all_in_one.html#_mocking_classes [2] http://spockframework.org/spock/docs/1.1/all_in_one.html#_1_1_rc_3_released_2016_10_17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Each time
build()is called on the pipeline builder it adds the commonDsl closure to the job builders. As a result the common DSL gets applied multiple times. Instead it should be applied only once.The text was updated successfully, but these errors were encountered: