Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#113 Gradle 5.4.1 fixes #114

Merged
merged 3 commits into from
Jun 24, 2019

Conversation

robinverduijn
Copy link
Contributor

Fix it so Task options work under Gradle 5.

The Option class has moved from org.gradle.api.internal.tasks.options to the org.gradle.api.tasks.options package.

This fixes the issue reported in #113

Signed-off-by: Robin Verduijn <robinverduijn.github@gmail.com>
The `Option` class has moved from `org.gradle.api.internal.tasks.options` to the `org.gradle.api.tasks.options` package.

Signed-off-by: Robin Verduijn <robinverduijn.github@gmail.com>
…ls as follows otherwise:

```
Installing oraclejdk8
$ export JAVA_HOME=~/oraclejdk8
$ export PATH="$JAVA_HOME/bin:$PATH"
$ ~/bin/install-jdk.sh --target "/home/travis/oraclejdk8" --workspace "/home/travis/.cache/install-jdk" --feature "8" --license "BCL"
install-jdk.sh 2019-05-02
Expected feature release number in range of 9 to 14, but got: 8
The command "~/bin/install-jdk.sh --target "/home/travis/oraclejdk8" --workspace "/home/travis/.cache/install-jdk" --feature "8" --license "BCL"" failed and exited with 3 during .
Your build has been stopped.
```

Signed-off-by: Robin Verduijn <robinverduijn.github@gmail.com>
@mnonnenmacher
Copy link
Contributor

Thanks for your contribution @robinverduijn, I will prepare a new release soon.

@mnonnenmacher mnonnenmacher merged commit 943ff24 into heremaps:master Jun 24, 2019
@robinverduijn
Copy link
Contributor Author

Thank you, Martin!

@robinverduijn robinverduijn deleted the gradle-5.4.1-fixes branch June 26, 2019 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants