Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support of Showing Local Events Location in Spirv #761

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Support of Showing Local Events Location in Spirv #761

merged 3 commits into from
Nov 11, 2024

Conversation

CapZTr
Copy link
Contributor

@CapZTr CapZTr commented Oct 25, 2024

In #760 Local events are added to witness graph. This PR supports showing source-level location information for Locals in Spirv code, since they are often related to control flows (Phi instructions) so that need to be treated specifically.

@hernanponcedeleon
Copy link
Owner

@CapZTr I thought this PR would need some changes based on the refactoring you are doing for #760, but maybe I am wrong.

Are they related or is this one completely independent?

@CapZTr
Copy link
Contributor Author

CapZTr commented Nov 8, 2024

@CapZTr I thought this PR would need some changes based on the refactoring you are doing for #760, but maybe I am wrong.

Are they related or is this one completely independent?

@hernanponcedeleon Changes of this PR are related to showing source location of Locals in Spir-V programs. Functions of the added code work independently with #760 , which extracts the information from IR and record it only. But this information will never be used, because the code for extracting Locals and adding them to the graph is not here.

@hernanponcedeleon
Copy link
Owner

If there are independent then we should move forward (sorry for the delay, I thought there was a dependency).

@CapZTr can you please rebase?

@natgavrilenko can you please review?

@natgavrilenko
Copy link
Collaborator

@natgavrilenko can you please review?

Will do before Monday the latest

@CapZTr CapZTr force-pushed the spirv-local-events-location branch from 74ec869 to fba0a09 Compare November 8, 2024 14:09
@CapZTr
Copy link
Contributor Author

CapZTr commented Nov 8, 2024

@CapZTr can you please rebase?

Done.

Tianrui Zheng added 2 commits November 11, 2024 09:51
add support to show source location of local events for spirv
d9b7868 
Signed-off-by: Tianrui Zheng <tianrui.zheng@huawei.com>
Modified how to handle phi definition id
30cd0a0 
Signed-off-by: Tianrui Zheng <tianrui.zheng@huawei.com>
@CapZTr CapZTr force-pushed the spirv-local-events-location branch from 4a6a5d8 to 30cd0a0 Compare November 11, 2024 08:51
Change putIfAbsent to computeIfAbsent
bbfb9f3 
Signed-off-by: Tianrui Zheng <tianrui.zheng@huawei.com>
@hernanponcedeleon hernanponcedeleon merged commit 749c055 into hernanponcedeleon:development Nov 11, 2024
1 check passed
@CapZTr CapZTr deleted the spirv-local-events-location branch November 11, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natgavrilenko natgavrilenko natgavrilenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CapZTr @hernanponcedeleon @natgavrilenko