Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove svcomp specific options #773

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Remove svcomp specific options #773

merged 3 commits into from
Nov 8, 2024

Conversation

hernanponcedeleon
Copy link
Owner

No description provided.

@hernan-poncedeleon
Set env variables to the beggining of svcomp script (we needthem to c…
494fc60 
…ompute version)
@hernan-poncedeleon
Remove svcomp options umin, umax, and step
6b3e9f1 
Signed-off-by: Hernan Ponce de Leon <hernanl.leon@huawei.com>
@hernan-poncedeleon
Remove unused variable and imports
7e2b3f0 
Signed-off-by: Hernan Ponce de Leon <hernanl.leon@huawei.com>
ThomasHaas
ThomasHaas approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@ThomasHaas ThomasHaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure that we do not want to introduce larger steps eventually?

Otherwise, LGTM.

@hernanponcedeleon
Copy link
Owner Author

Are we sure that we do not want to introduce larger steps eventually?

For next year, I am hoping to even get rid of the SVCOMPRunner class and dump/loads from files.
If we eventually want to give larger steps, that will probably also be useful for when we increase the loops of non fully unrolled loops.
In summary, if we add that it wont be svcomp specific

@hernanponcedeleon hernanponcedeleon merged commit f777ce9 into development Nov 8, 2024
1 check passed
@hernanponcedeleon hernanponcedeleon deleted the svcomp branch November 8, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasHaas ThomasHaas ThomasHaas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hernanponcedeleon @ThomasHaas @hernan-poncedeleon