-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace heroku/nodejs-engine with libcnb.rs implementation #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
reviewed
Feb 27, 2022
Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
Malax
approved these changes
Mar 8, 2022
Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
This was referenced Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
heroku/nodejs-engine
from a bash based buildpack to a rust and libcnb.rs version.Most of the functionality stays the same, but there are some notable differences:
heroku/nodejs-engine
no longer installsyarn
. Theheroku/nodejs-yarn
buildpack can install yarn today, and that's the more correct place to install it.semver-node
crate, which has support for Node's flavor of semver.heroku/nodejs-engine
no longer installsjq
andyj
. We're now usingserde
serialization and deserialization and rust types for working withtoml
andjson
files.heroku/nodejs-yarn
andheroku/nodejs-npm
now install their ownjq
instead of expecting it to be installed byheroku/nodejs-enginge
.WEB_MEMORY
andWEB_CONCURRENCY
has been replaced with a rust and exec.d implementation. The new implementation supports cgroups v2.heroku/nodejs-engine
is now independently usable. Simple node.js apps with anindex.js
orserver.js
and no dependencies can be built withheroku/nodejs-engine
alone.Releasing
Because the installation of
jq
has changed, we need to release thenpm
andyarn
buildpack before releasing theengine
buildpack. Suggested release order:heroku/nodejs-npm
heroku/nodejs-yarn
heroku/nodejs-engine
heroku/nodejs
heroku/nodejs-function
GUS-W-W-10729118