Reintroduce [[stacks]] table to workaround release issues.
#210
Conversation
|
I've triggered Dependabot manually via https://github.com/heroku/procfile-cnb/network/updates to pick up the libcnb 0.19.0 release needed for |
Thanks. I went looking for a button, but didn't find it and opened #212 manually. I'll close that one. |
|
It's kinda tucked away: Main repo view -> Insights tab -> Dependency graph on side menu -> Dependabot tab. |
joshwlewis
force-pushed
the
add-stacks-table
branch
from
25190b4 to
9e3c7de
Compare
There was a problem hiding this comment.
The release date will need updating in the changelog before re-release:
https://github.com/heroku/procfile-cnb/blob/306b4f2b83146fd90f455a30ce8a6b1fbfbbe3b2/CHANGELOG.md?plain=1#L10
I'm happy for that change to be made in this PR, or as a separate PR - whatever you prefer :-)
|
Ah auto-merge beat me to it. I'll open a PR for the date :-) |
|
Opened #213. |
Since the original release was delayed due to the packaging step failing (see #210). (I've used 28th not 27th for the date, since we/the automation use UTC dates in the changelog.)
The 3.0.0 release is currently blocked: https://github.com/heroku/procfile-cnb/actions/runs/8025023370/job/21924849039. It's failing with
ERROR: saving image: no compatible stacks among provided buildpacks.The issue is that
pack buildpack packagerequires[[stacks]]to be present inbuildpack.toml, which is unexpected (and maybe unintentional), since[[stacks]]were deprecated in Buildpack API 0.10.We could wait for an upstream fix (like buildpacks/pack#2081 🤞🏻 ), or we could workaround the issue by adding the
[[stacks]]table back in.Functionally, having no
[[stacks]]table and having[[stacks]] id = "*"seem to be the same. And while the[[stacks]]table is deprecated, there isn't any messaging saying so in the pack output. So, the only downside that I see to adding[[stacks]]back in is that we'll probably want to remove it again later.