Add explicit support for heroku-* stacks #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
approved these changes
Apr 4, 2022
jabrown85
approved these changes
Apr 4, 2022
joshwlewis
force-pushed
the
explicit-stacks
branch
from
33c75f0 to
544d406
Compare
This was referenced Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some older versions of
pack(prior to0.24.1) fail to recognize this buildpack's*stack support. By adding theheroku-*stacks explicitly, we ensure this buildpack works on olderpackversions (at least onheroku-*stacks).This issue bit a user here: https://cloud-native.slack.com/archives/C033DV8D9FB/p1649105014643919
And caused another buildpack a bit of trouble here: heroku/buildpacks-nodejs#231 (review)