Switch from stacks to targets AKA "Stay on target" #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps the libcnb group with 3 updates in the / directory: [libcnb](https://github.com/heroku/libcnb.rs), [libherokubuildpack](https://github.com/heroku/libcnb.rs) and [libcnb-test](https://github.com/heroku/libcnb.rs). Updates `libcnb` from 0.17.0 to 0.19.0 - [Release notes](https://github.com/heroku/libcnb.rs/releases) - [Changelog](https://github.com/heroku/libcnb.rs/blob/main/CHANGELOG.md) - [Commits](heroku/libcnb.rs@v0.17.0...v0.19.0) Updates `libherokubuildpack` from 0.17.0 to 0.21.0 - [Release notes](https://github.com/heroku/libcnb.rs/releases) - [Changelog](https://github.com/heroku/libcnb.rs/blob/main/CHANGELOG.md) - [Commits](heroku/libcnb.rs@v0.17.0...v0.21.0) Updates `libcnb-test` from 0.17.0 to 0.19.0 - [Release notes](https://github.com/heroku/libcnb.rs/releases) - [Changelog](https://github.com/heroku/libcnb.rs/blob/main/CHANGELOG.md) - [Commits](heroku/libcnb.rs@v0.17.0...v0.19.0) --- updated-dependencies: - dependency-name: libcnb dependency-type: direct:production update-type: version-update:semver-minor dependency-group: libcnb - dependency-name: libherokubuildpack dependency-type: direct:production update-type: version-update:semver-minor dependency-group: libcnb - dependency-name: libcnb-test dependency-type: direct:production update-type: version-update:semver-minor dependency-group: libcnb ... Signed-off-by: dependabot[bot] <support@github.com>
schneems
force-pushed
the
schneems/upgrade-libcnb
branch
from
f2f6e54
to
820b1a0
Compare
The layer trait interface was changed to mutable in heroku/libcnb.rs#669
Buildpack API 0.10 removed the concept of stacks in favor of targets heroku/libcnb.rs#773. This commit works to upgrade applications in place by migrating metadata to support the new serialization format. This is supported by implementing TryMigrate from the `magic_migrate` crate https://docs.rs/magic_migrate/latest/magic_migrate/macro.try_migrate_link.html. https://www.youtube.com/watch?v=NnP5iDKwuwk
schneems
force-pushed
the
schneems/upgrade-libcnb
branch
from
820b1a0
to
220b2eb
Compare
schneems
force-pushed
the
schneems/upgrade-libcnb
branch
from
5c95a12
to
79758c4
Compare
schneems
force-pushed
the
schneems/upgrade-libcnb
branch
from
79758c4
to
557d888
Compare
edmorley
reviewed
May 13, 2024
Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
- Add explanation for when stacks can be removed - Move "targets" closer to "stacks" as they're logically tied together.
schneems
force-pushed
the
schneems/upgrade-libcnb
branch
2 times, most recently
from
610d881
to
b11fbb1
Compare
This buildpack does not support heroku-24 (yet) remove this stack from the TargetId struct. It also supports heroku-20 which was previously not present.
schneems
force-pushed
the
schneems/upgrade-libcnb
branch
from
b11fbb1
to
d0c1bbd
Compare
This was referenced May 17, 2024
Merged
heroku-linguist bot
added a commit
to heroku/cnb-builder-images
that referenced
this pull request
May 20, 2024
* Update heroku/buildpacks-ruby to v3.0.0 ## heroku/ruby ### Changed - The buildpack now implements Buildpack API 0.10 instead of 0.9, and so requires `lifecycle` 0.17.x or newer. ([#283](heroku/buildpacks-ruby#283)) ### Added - Added support for Ubuntu 24.04 (and thus Heroku-24 / `heroku/builder:24`). ([#284](heroku/buildpacks-ruby#284)) * Add Ruby to heroku/builder:24 --------- Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com> Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buildpack API 0.10 removed the concept of stacks in favor of targets heroku/libcnb.rs#773.
This commit works to upgrade applications in place by migrating metadata to support the new serialization format. This is supported by implementing TryMigrate from the
magic_migratecrate https://docs.rs/magic_migrate/latest/magic_migrate/macro.try_migrate_link.html.https://www.youtube.com/watch?v=NnP5iDKwuwk
Notably, this does NOT introduce support for
heroku-24and multiple architectures. That work will come after upgrading from stacks to targets.