feat: add generation info to spaces:info and spaces:wait commands #3033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eablack
approved these changes
Oct 14, 2024
| } | ||
|
|
||
| const {body: space} = await this.heroku.get<Heroku.Space>(`/spaces/${spaceName}`, {headers}) | ||
| const {body: updatedSpace} = await this.heroku.get<Space>(`/spaces/${spaceName}`, {headers}) | ||
| const space: SpaceWithOutboundIps = updatedSpace |
There was a problem hiding this comment.
Rather than setting the body's updatedSpace variable as Space type and then immediately setting it as SpaceWithOutboundIps type, couldn't we just set it as SpaceWithOutboundIps? So like:
const {body: space} = await this.heroku.get<SpaceWithOutboundIps>(`/spaces/${spaceName}`, {headers})There was a problem hiding this comment.
Good thought, thank you! Updated.
k80bowman
force-pushed
the
k80/fir-spaces-info
branch
from
947f239 to
37cd362
Compare
k80bowman
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
k80bowman
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds space generation to the output from the
spaces:infoandspaces:waitcommands.Testing
yarn && yarn build./bin/run spaces:info test-fir-dev-toolsand verify that the generation is included in the output./bin/run spaces:info test-fir-dev-tools --jsonand verify that the generation is included in the output./bin/run spaces:wait test-fir-dev-toolsand verify that the generation is included in the output./bin/run spaces:wait test-fir-dev-tools --jsonand verify that the generation is included in the outputInternal work item