Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add telemetry:update #3050

Merged
merged 4 commits into from
Oct 22, 2024
Merged

Conversation

eablack
Copy link
Contributor

@eablack eablack commented Oct 21, 2024

GUS WI

Description

Adds telemetry:update, which allows for updating one or more attributes on a telemetry drain. Also included in this PR is a switch to --signals rather than --signal for input to telemetry:add. Also added missing examples to existing telemetry commands

@eablack eablack self-assigned this Oct 21, 2024
@eablack eablack changed the base branch from main to prerelease/10.0.0-alpha October 21, 2024 23:41
@eablack eablack temporarily deployed to AcceptanceTests October 22, 2024 17:44 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests October 22, 2024 17:44 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests October 22, 2024 17:49 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests October 22, 2024 17:49 — with GitHub Actions Inactive
@eablack eablack marked this pull request as ready for review October 22, 2024 17:51
@eablack eablack requested a review from a team as a code owner October 22, 2024 17:51
@eablack eablack force-pushed the eb/add-telemetry-update-command branch from 61f27af to 288f930 Compare October 22, 2024 17:54
@eablack eablack temporarily deployed to AcceptanceTests October 22, 2024 17:54 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests October 22, 2024 17:54 — with GitHub Actions Inactive
Copy link
Contributor

@sbosio sbosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work!

@eablack eablack merged commit 65c02fb into prerelease/10.0.0-alpha Oct 22, 2024
8 checks passed
@eablack eablack deleted the eb/add-telemetry-update-command branch October 22, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants