Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dyno restart and stop with fir support #3061

Merged
merged 6 commits into from
Oct 29, 2024

Conversation

eablack
Copy link
Contributor

@eablack eablack commented Oct 28, 2024

GUS WI

Description

This reworks ps:stop and ps:restart to work with new fir-compatible APIs. Aligning with heroku logs, we will now require explicit flags for dyno name, --dyno, and dyno type, --type. We'll continue supporting passing DYNO as an argument as a deprecated arg.

Testing

With a fir app,

  1. Pull down this branch and yarn build
  2. Find the name of a dyno and its type by running heroku ps -a APP_NAME
  3. ./bin/run ps stop --dyno DYNO_NAME
  4. ./bin/run ps restart --dyno DYNO_NAME
  5. ./bin/run ps stop --type DYNO_TYPE
  6. ./bin/run ps restart --type DYNO_TYPE
  7. Do 3-6 with a cedar app

@eablack eablack changed the title Eb/update dyno restart and stop update dyno restart and stop with fir support Oct 28, 2024
@eablack eablack temporarily deployed to AcceptanceTests October 28, 2024 21:29 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests October 28, 2024 21:29 — with GitHub Actions Inactive
@eablack eablack marked this pull request as ready for review October 28, 2024 21:40
@eablack eablack requested a review from a team as a code owner October 28, 2024 21:40
Copy link
Contributor

@k80bowman k80bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well!

@eablack eablack merged commit bd8a15e into prerelease/10.0.0-alpha Oct 29, 2024
8 checks passed
@eablack eablack deleted the eb/update-dyno-restart-and-stop branch October 29, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants