update dyno restart and stop with fir support #3061
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GUS WI
Description
This reworks
ps:stop
andps:restart
to work with new fir-compatible APIs. Aligning withheroku logs
, we will now require explicit flags for dyno name,--dyno
, and dyno type,--type
. We'll continue supporting passing DYNO as an argument as a deprecated arg.Testing
With a fir app,
yarn build
heroku ps -a APP_NAME
./bin/run ps stop --dyno DYNO_NAME
./bin/run ps restart --dyno DYNO_NAME
./bin/run ps stop --type DYNO_TYPE
./bin/run ps restart --type DYNO_TYPE