Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update help text and dyno type/process type flag names #3068

Merged
merged 6 commits into from
Nov 1, 2024
Merged

Update help text and dyno type/process type flag names #3068

merged 6 commits into from
Nov 1, 2024

Conversation

eablack
Copy link
Contributor

@eablack eablack commented Oct 31, 2024 •
edited
Loading

GUS WI

Description

This updates text based on cx feedback. It includes standardizing ps:stop, ps:restart, and logs on --process-type and --dyno-name.

Testing

  1. Pull down branch and yarn build
  2. Run heroku logs, heroku ps:stop and heroku ps:restart with new flag names.

@eablack eablack temporarily deployed to AcceptanceTests November 1, 2024 16:44 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests November 1, 2024 16:50 — with GitHub Actions Inactive
@eablack eablack force-pushed the eb/update-type-dyno-flags-and-help-text branch from eff005a to c6f839b Compare November 1, 2024 16:52
@eablack eablack temporarily deployed to AcceptanceTests November 1, 2024 16:52 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests November 1, 2024 17:01 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests November 1, 2024 17:14 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests November 1, 2024 17:14 — with GitHub Actions Inactive
@eablack eablack marked this pull request as ready for review November 1, 2024 17:18
@eablack eablack requested a review from a team as a code owner November 1, 2024 17:18
@eablack eablack merged commit 481cbf2 into prerelease/10.0.0-alpha Nov 1, 2024
8 checks passed
@eablack eablack deleted the eb/update-type-dyno-flags-and-help-text branch November 1, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k80bowman k80bowman k80bowman approved these changes

@SandyPantsLai SandyPantsLai SandyPantsLai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eablack @SandyPantsLai @k80bowman