Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get buildpacks from latest release for fir apps #3092

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

eablack
Copy link
Contributor

@eablack eablack commented Nov 13, 2024

GUS WI

Description

With fir, buildpack data is now configured via project.toml and the active state of what buildpacks are installed for an app is not stored explicitly in Platform API. For the buildpacks command, we'll now display that state as derived from the oci image from the latest release of an app.

Testing

  1. pull down this branch and yarn build
  2. ./bin/run buildpacks --app APP where APP is a cedar app
  3. see no difference from what is in production
  4. ./bin/run buildpacks --app APP where APP is a fir app
  5. See that it does not fail, and displays the relevant cnb buildpack(s)

@eablack eablack marked this pull request as ready for review November 14, 2024 00:57
@eablack eablack requested a review from a team as a code owner November 14, 2024 00:57
Copy link
Contributor

@sbosio sbosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@eablack eablack merged commit 953c91f into prerelease/10.0.0-alpha Nov 14, 2024
8 checks passed
@eablack eablack deleted the eb/show-fir-buildpacks branch November 14, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants