Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch from 3.add-ons-sso to 3.sdk #3180

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

eablack
Copy link
Contributor

@eablack eablack commented Jan 17, 2025

https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE0000285wZdYAI/view

Description

Web services is deprecating 3.add-ons-sso variant and has moved its functionality to 3.sdk. This updates our use of that variant.

Testing

Because of the interaction with sudo, it's a bit annoying to test this. Here's how I tested:

  1. Pull down this branch
  2. In commands/addons/open.ts, comment out lines 97 and 99. Also comment out lines 101-122.
  3. yarn build
  4. `./bin/run addons:open DATABASE_NAME --app APP_NAME

@eablack eablack requested a review from a team as a code owner January 17, 2025 00:40
@eablack eablack changed the title Switch from 3.add-ons-sso to 3.sdk chore: witch from 3.add-ons-sso to 3.sdk Jan 21, 2025
@eablack eablack changed the title chore: witch from 3.add-ons-sso to 3.sdk chore: switch from 3.add-ons-sso to 3.sdk Jan 21, 2025
Copy link
Contributor

@zwhitfield3 zwhitfield3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and testing was successful.

@eablack eablack merged commit d6a9cd7 into main Jan 21, 2025
8 checks passed
@eablack eablack deleted the eb/switch-3.add-ons-sso-to-3.sdk branch January 21, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants