Skip to content

Commit

Permalink
Use shimmed Ruby buildpack instead of the prototype hybrid CNB (#282)
Browse files Browse the repository at this point in the history
The previously deployed Ruby buildpack is based on the "hybrid" approach https://github.com/heroku/heroku-buildpack-ruby. Essentially Terence added support for CNB into the existing buildpack. This works, but it's not taking advantage of most of the features in CNB. It's really not too different than using the "shim" buildpack.

(The *shim* is a wrapper around any legacy/v2 buildpack that allows it to interface with CNB)

The idea is that we'll use the shim buildpack for now and switch over once a native CNB implementation in Rust is ready.

GUS-W-11461073
  • Loading branch information
schneems authored Sep 27, 2022
1 parent 1304714 commit 8f6c8b6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions buildpacks-18/builder.toml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ version = "0.14.1"

[[buildpacks]]
id = "heroku/ruby"
uri = "docker://public.ecr.aws/heroku-buildpacks/heroku-ruby-buildpack@sha256:3eeb3773cdbd29d4fb0d578f7781fe8c525de73593480e2740b7143262e5bef5"
uri = "https://cnb-shim.herokuapp.com/v1/heroku/ruby?version=0.0.0&name=Ruby"

[[buildpacks]]
id = "heroku/procfile"
Expand Down Expand Up @@ -55,7 +55,7 @@ version = "0.14.1"
[[order]]
[[order.group]]
id = "heroku/ruby"
version = "0.1.3"
version = "0.0.0"

[[order.group]]
id = "heroku/procfile"
Expand Down
4 changes: 2 additions & 2 deletions buildpacks-20/builder.toml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ version = "0.14.1"

[[buildpacks]]
id = "heroku/ruby"
uri = "docker://public.ecr.aws/heroku-buildpacks/heroku-ruby-buildpack@sha256:3eeb3773cdbd29d4fb0d578f7781fe8c525de73593480e2740b7143262e5bef5"
uri = "https://cnb-shim.herokuapp.com/v1/heroku/ruby?version=0.0.0&name=Ruby"

[[buildpacks]]
id = "heroku/procfile"
Expand Down Expand Up @@ -56,7 +56,7 @@ version = "0.14.1"
[[order]]
[[order.group]]
id = "heroku/ruby"
version = "0.1.3"
version = "0.0.0"

[[order.group]]
id = "heroku/procfile"
Expand Down

0 comments on commit 8f6c8b6

Please sign in to comment.