Reinstate Gradle support for heroku/buildpacks:{18,20}
#264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
reviewed
Jun 15, 2022
There was a problem hiding this comment.
Could you add gradle to the getting-started-guide matrix here?
https://github.com/heroku/builder/blob/4710f39ecf2a7df98bff278fd9a3281a1b964579/.circleci/config.yml#L145-L164
edmorley
approved these changes
Jun 15, 2022
heroku-linguist bot
added a commit
that referenced
this pull request
Sep 17, 2024
## heroku/python ### Added - The Python version can now be configured using a `.python-version` file. Both the `3.X` and `3.X.Y` version forms are supported. ([#272](heroku/buildpacks-python#272)) ### Changed - pip is now only available during the build, and is longer included in the final app image. ([#264](heroku/buildpacks-python#264)) - Improved the error messages shown when an end-of-life or unknown Python version is requested. ([#272](heroku/buildpacks-python#272))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
heroku/javapreviously supported Gradle by mixing in the shimmedheroku/gradlebuildpack. When we decided to make a clean cut and not have shimmed buildpacks in the CNB repository, support for Gradle inheroku/javawas dropped.This is obviously a major breaking change and this PR reinstates Gradle support by mirroring the order definition that was previously in
heroku/java. This is not a complete fix since users that explicitly usedheroku/java(i.e.--buildpack heroku/javawithpack) will still get detection failures for Gradle. However, using the builder without explicit buildpacks will work fine for Gradle projects.Closes GUS-W-11298364