Fix broken upstream docs URL in deprecation message #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upstream CNB project has rearranged a number of the docs pages, breaking some existing links such as: https://buildpacks.io/docs/tools/pack/cli/pack_config_default-builder/ I've filed buildpacks/docs#673 for potentially adding redirects, however, for the deprecation warning use-case, it makes more sense for us to just inline the CLI command rather than link out to the docs.
Malax
approved these changes
Mar 8, 2024
|
Hmm so trying now the link works (it didn't last night). It seems this may have been fixed by: I think it still makes sense for us to inline the CLI command rather than link to an external page (since the builder image will be frozen at some point, and docs links may change again in the future), so I'll merge this anyway :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream CNB project has rearranged a number of the docs pages, breaking some existing links such as:
https://buildpacks.io/docs/tools/pack/cli/pack_config_default-builder/
I've filed buildpacks/docs#673 for potentially adding redirects, however, for the deprecation warning use-case, it makes more sense for us to just inline the CLI command rather than link out to the docs.
GUS-W-15211765.