Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$1 should be escaped #74

Merged
merged 1 commit into from
Jul 9, 2019
Merged

$1 should be escaped #74

merged 1 commit into from
Jul 9, 2019

Conversation

kwlockwo
Copy link
Contributor

@kwlockwo kwlockwo commented Jul 9, 2019

No description provided.

@kwlockwo kwlockwo self-assigned this Jul 9, 2019
@kwlockwo
Copy link
Contributor Author

kwlockwo commented Jul 9, 2019 

~ $ cat /app/.apt/usr/bin/google-chrome
#!/usr/bin/env bash
if [ $1 = "--version" ]; then
  exec $HOME/.apt/opt/google/chrome/chrome --version
elif [ $1 = "--product-version" ]; then
  exec $HOME/.apt/opt/google/chrome/chrome --product-version
else
  exec $HOME/.apt/opt/google/chrome/chrome --headless --no-sandbox --disable-gpu --remote-debugging-port=9222 $@
fi
~ $ google-chrome --version
Google Chrome 75.0.3770.100 unknown
~ $ google-chrome --product-version
75.0.3770.100

@kwlockwo kwlockwo mentioned this pull request Jul 9, 2019
Merged
@kwlockwo kwlockwo requested a review from jabrown85 July 9, 2019 02:54
@jabrown85 jabrown85 merged commit 529017e into master Jul 9, 2019
@jabrown85 jabrown85 deleted the keith-escape-shim-input branch July 9, 2019 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jabrown85 jabrown85 jabrown85 approved these changes

Assignees

@kwlockwo kwlockwo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kwlockwo @jabrown85