Blackfire: tests, agent v2, separate agent package, blackfireio/integration-heroku buildpack support #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
all env vars are shared between agent and extension, with the exception of the socket (BLACKFIRE_SOCKET vs BLACKFIRE_AGENT_SOCKET) we are hard-coding the log file and agent socket values to ensure the basics always work; passing the socket directly to the agent
schneems
approved these changes
Jun 25, 2021
if users have https://github.com/blackfireio/integration-heroku set as a buildpack that runs before ours, use that instead of our own package
dzuelke
force-pushed
the
blackfire-agent-package
branch
from
f638c49 to
79f4553
Compare
schneems
approved these changes
Jun 25, 2021
Merged
lolautruche
reviewed
Jun 25, 2021
|
We can't do that for compliance reasons, unfortunately - released versions must be fixed and mirrored by us for audit log purposes. Longer-term, I guess the best solution is for us to simply not provide the CLI at all, but it'd be great if the user experience was reasonable in that case (i.e., meaningful error message instructing folks to install your buildpack). Of course, another solution would be for you to also provide the extension packages ;) We can tackle that after I migrated the platform installer plugin to Composer v2. |
|
OK understood. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, the
ext-blackfireextension also always bundled theblackfire-agentprogram. That program relays telemetry from a language runtime to the Blackfire servers in the background.This PR: