Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 #767

Merged
merged 12 commits into from
Dec 19, 2024
Merged

PHP 8.4 #767

merged 12 commits into from
Dec 19, 2024

Conversation

dzuelke
Copy link
Contributor

@dzuelke dzuelke commented Nov 22, 2024

No blackfire or newrelic extension builds yet with support for 8.4. The phalcon extension is incompatible with 8.4 (they always get new releases some time later), and pcov needs a fix and release first: krakjoe/pcov#111. The imap extension has moved to PECL.

The heroku-20 stack is not getting this version because the stack is already deprecated.

GUS-W-17226361

@dzuelke dzuelke requested a review from a team as a code owner November 22, 2024 17:06
@dzuelke dzuelke marked this pull request as draft November 22, 2024 17:17
@dzuelke dzuelke marked this pull request as ready for review November 22, 2024 23:12
bin/compile Show resolved Hide resolved
@dzuelke
Copy link
Contributor Author

dzuelke commented Nov 29, 2024

(n.b. waiting for merge/release of composer/composer#12217, and the Black Friday weekend to tide over)

There is no more E_STRICT for error_reporting, and session.sid_length is gone.

The imap extension has moved to PECL.

No newrelic extension builds yet with support for 8.4. The phalcon extension is incompatible with 8.4 (they always get new releases some time later).

The heroku-20 stack is not getting this version because the stack is already deprecated.

GUS-W-17226361
We currently perform the install using a bootstrapped minimal 8.3, but it doesn't hurt to be ready.
Just for consistency with the version we bootstrap, since a few of the platform installer/generator related tests run directly in RSpec with the 'local' PHP, not via Hatchet
…GHA step summary

just in case the source document does not have a trailing newline, we add one to ensure the closing six backticks are interpreted correctly
@dzuelke
Copy link
Contributor Author

dzuelke commented Dec 19, 2024

@dzuelke dzuelke merged commit acbbab9 into main Dec 19, 2024
28 checks passed
@dzuelke dzuelke deleted the php84 branch December 19, 2024 16:34
@heroku-linguist heroku-linguist bot mentioned this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants