-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8.4 #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
approved these changes
Nov 23, 2024
(n.b. waiting for merge/release of composer/composer#12217, and the Black Friday weekend to tide over) |
(no effect in actual CI because that filter is disabled there)
We do not have support for PHP 5 or PHP 7.[012] anymore.
We do not have support for PHP 5 or PHP 7.0 anymore.
There is no more E_STRICT for error_reporting, and session.sid_length is gone. The imap extension has moved to PECL. No newrelic extension builds yet with support for 8.4. The phalcon extension is incompatible with 8.4 (they always get new releases some time later). The heroku-20 stack is not getting this version because the stack is already deprecated. GUS-W-17226361
We currently perform the install using a bootstrapped minimal 8.3, but it doesn't hurt to be ready.
Just for consistency with the version we bootstrap, since a few of the platform installer/generator related tests run directly in RSpec with the 'local' PHP, not via Hatchet
…GHA step summary just in case the source document does not have a trailing newline, we add one to ensure the closing six backticks are interpreted correctly
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No blackfire or newrelic extension builds yet with support for 8.4. The phalcon extension is incompatible with 8.4 (they always get new releases some time later), and pcov needs a fix and release first: krakjoe/pcov#111. The imap extension has moved to PECL.
The heroku-20 stack is not getting this version because the stack is already deprecated.
GUS-W-17226361