Remove unused vendor/test-utils #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malax
approved these changes
Aug 11, 2020
Since the unit tests instead use the utilities in this separate file: https://github.com/heroku/heroku-buildpack-python/blob/419ef479969c4d5945f2c0620292229ef464f4c8/test/utils A changelog entry has been added since whilst this file is for internal testing only, the buildpack's `vendor` directory is put on `PATH`, so in theory it could have been called outside the buildpack (though this seems extremely unlikely since the script isn't very useful externally). Fixes #1027. Closes @W-7918496@.
edmorley
force-pushed
the
rm-vendor-test-utils
branch
from
cfa8ba0
to
319dd55
Compare
dryan
pushed a commit
to dryan/heroku-buildpack-python
that referenced
this pull request
Nov 19, 2020
Since the unit tests instead use the utilities in this separate file: https://github.com/heroku/heroku-buildpack-python/blob/419ef479969c4d5945f2c0620292229ef464f4c8/test/utils A changelog entry has been added since whilst this file is for internal testing only, the buildpack's `vendor/` directory is put on `PATH`, so in theory it could have been called outside the buildpack (though this seems extremely unlikely since the script isn't very useful externally). Fixes heroku#1027. Closes @W-7918496@.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the unit tests instead use the utilities in this separate file:
https://github.com/heroku/heroku-buildpack-python/blob/419ef479969c4d5945f2c0620292229ef464f4c8/test/utils
A changelog entry has been added since whilst this file is for internal testing only, the buildpack's
vendor/directory is put onPATH, so in theory it could have been called outside the buildpack (though this seems extremely unlikely since the script isn't very useful externally).Fixes #1027.
Closes @W-7918496@.